Develop #3421
Closed
Develop #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktor-Kost
suggested changes
Jul 31, 2023
src/style.css
Outdated
Comment on lines
22
to
60
| .stars--1 .stars__star:nth-child(-n + 1) { | ||
| margin: 0 4px; | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(../src/images/star-active.svg); | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--2 .stars__star:nth-child(-n + 2) { | ||
| margin: 0 4px; | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(../src/images/star-active.svg); | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--3 .stars__star:nth-child(-n + 3) { | ||
| margin: 0 4px; | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(../src/images/star-active.svg); | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--4 .stars__star:nth-child(-n + 4) { | ||
| margin: 0 4px; | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(../src/images/star-active.svg); | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--5 .stars__star:nth-child(-n + 5) { | ||
| margin: 0 4px; | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(../src/images/star-active.svg); | ||
| background-repeat: no-repeat; | ||
| } |
There was a problem hiding this comment.
- you have most of styles at the common class selector stars__star
- you can list as a group
Suggested change
| .stars--1 .stars__star:nth-child(-n + 1) { | |
| margin: 0 4px; | |
| width: 16px; | |
| height: 16px; | |
| background-image: url(../src/images/star-active.svg); | |
| background-repeat: no-repeat; | |
| } | |
| .stars--2 .stars__star:nth-child(-n + 2) { | |
| margin: 0 4px; | |
| width: 16px; | |
| height: 16px; | |
| background-image: url(../src/images/star-active.svg); | |
| background-repeat: no-repeat; | |
| } | |
| .stars--3 .stars__star:nth-child(-n + 3) { | |
| margin: 0 4px; | |
| width: 16px; | |
| height: 16px; | |
| background-image: url(../src/images/star-active.svg); | |
| background-repeat: no-repeat; | |
| } | |
| .stars--4 .stars__star:nth-child(-n + 4) { | |
| margin: 0 4px; | |
| width: 16px; | |
| height: 16px; | |
| background-image: url(../src/images/star-active.svg); | |
| background-repeat: no-repeat; | |
| } | |
| .stars--5 .stars__star:nth-child(-n + 5) { | |
| margin: 0 4px; | |
| width: 16px; | |
| height: 16px; | |
| background-image: url(../src/images/star-active.svg); | |
| background-repeat: no-repeat; | |
| } | |
| .stars--1 .stars__star:nth-child(-n + 1), | |
| .stars--2 .stars__star:nth-child(-n + 2), | |
| .stars--3 .stars__star:nth-child(-n + 3), | |
| .stars--4 .stars__star:nth-child(-n + 4), | |
| .stars--5 .stars__star:nth-child(-n + 5) { | |
| background-image: url(../src/images/star-active.svg); | |
| } |
| } | ||
|
|
||
| .stars__star { | ||
| margin: 0 4px; |
There was a problem hiding this comment.
it's better use :not(:last-child) to set margin-right to all stars besides last one
src/index.html
Outdated
Comment on lines
45
to
48
| <div class="stars__star c"></div> | ||
| <div class="stars__star c"></div> | ||
| <div class="stars__star c"></div> | ||
| <div class="stars__star c"></div> |
There was a problem hiding this comment.
remove redundant selectors
Suggested change
| <div class="stars__star c"></div> | |
| <div class="stars__star c"></div> | |
| <div class="stars__star c"></div> | |
| <div class="stars__star c"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> |
src/index.html
Outdated
| </div> | ||
|
|
||
| <div class="stars stars--5"> | ||
| <div class="stars__star c"></div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://DudeMood.github.io/layout_stars/
https://DudeMood.github.io/layout_stars/report/html_report/